Fix startup crash: keep ShellViewModel.LoadAsync on the UI thread#10
Merged
Conversation
LoadAsync used ConfigureAwait(false), so after the store load the continuation resumed on a thread-pool thread and RebuildCliChoices() mutated CliChoices — an ObservableCollection already bound to the CLI switcher — off the UI thread. WinRT rejects the cross-thread collection-changed marshal with RPC_E_WRONG_THREAD (HRESULT 0x8001010E), crashing the app at first launch. Switch to ConfigureAwait(true) and document why. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShellViewModel.LoadAsyncusedConfigureAwait(false), so after_store.LoadAsyncthe continuation resumed on a thread-pool thread.RebuildCliChoices()then mutatedCliChoices— anObservableCollectionalready bound to the CLI switcher — off the UI thread, which WinRT rejects withRPC_E_WRONG_THREAD(HRESULT 0x8001010E).ConfigureAwait(true)and added a comment explaining why. CHANGELOG updated under theFixedsection.Test plan
ShellPage.OnLoaded.🤖 Generated with Claude Code